Upgrade checkout and java-setup actions to version v4

[mcruzdev]

Fixes #38549

[gastaldi]

Nice! Can you also bump actions/checkout to v4? Thanks

[gastaldi]

BTW some tests are going to fail because of this change, you need to run mvn clean verify -Dsnap in the integration-tests/maven directory

[mcruzdev]

Hi @gastaldi I executed the command into the specified module and works well. I upgraded the checkout action too.

[gastaldi]

Ah sorry, I think the correct command is something like:
mvn clean install -Dsnap -Dit.test=CreateExtensionMojoIT -Dtest=CreateExtensionMojoIT

Error:  Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 30.89 s <<< FAILURE! -- in io.quarkus.maven.it.CreateExtensionMojoIT
Error:  io.quarkus.maven.it.CreateExtensionMojoIT.testCreateQuarkiverseExtension(TestInfo) -- Time elapsed: 6.987 s <<< FAILURE!
java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): CreateExtensionMojoIT/testCreateQuarkiverseExtension/quarkus-my-quarkiverse-ext_.github_workflows_build.yml] 
Path:
  target/test-classes/output/create-quarkiverse-extension/quarkus-my-quarkiverse-ext/.github/workflows/build.yml
and path:
  src/test/resources/__snapshots__/CreateExtensionMojoIT/testCreateQuarkiverseExtension/quarkus-my-quarkiverse-ext_.github_workflows_build.yml
do not have same content:

Changed content at line 47:
expecting:
  ["      - uses: actions/checkout@v3"]
but was:
  ["      - uses: actions/checkout@v4"]

Changed content at line 49:
expecting:
  ["        uses: actions/setup-java@v3"]
but was:
  ["        uses: actions/setup-java@v4"]

	at io.quarkus.devtools.testing.SnapshotTesting.lambda$assertThatMatchSnapshot$0(SnapshotTesting.java:183)
	at io.quarkus.devtools.testing.SnapshotTesting.withSnapshotsDir(SnapshotTesting.java:97)
	at io.quarkus.devtools.testing.SnapshotTesting.assertThatMatchSnapshot(SnapshotTesting.java:160)
	at io.quarkus.devtools.testing.SnapshotTesting.assertThatMatchSnapshot(SnapshotTesting.java:136)
	at io.quarkus.maven.it.CreateExtensionMojoIT.testCreateQuarkiverseExtension(CreateExtensionMojoIT.java:118)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

[gastaldi]

Can you squash those commits before we merge this?

[mcruzdev]

I accidentally made a merge. Now, is ok!

[mcruzdev]

I am fixing the broken tests.

EDIT: Done @gastaldi

[mcruzdev]

@gastaldi this issue is related to the pull request or is just a flaky test as quarkus said?

[gastaldi]

The ones in independent-projects/tools/devtools-testing seem related to this change 🤔

[gastaldi]

Please squash all commits before we merge this

[mcruzdev]

Hi @gastaldi, done! Thank you for the support!

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 94d6966.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✔️	JVM Tests - JDK 17			Logs	Raw logs	🚧
✖	JVM Tests - JDK 21	Build	Failures	Logs	Raw logs	🚧

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 21 #

- Failing: integration-tests/virtual-threads/jms-virtual-threads 

📦 integration-tests/virtual-threads/jms-virtual-threads

✖ io.quarkus.it.vthreads.jms.VirtualThreadTest.testAlert - History - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.artemis.core.deployment.DevServicesArtemisProcessor#startArtemisDevService threw an exception: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=quay.io/artemiscloud/activemq-artemis-broker:1.0.18, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=org.testcontainers.utility.ImageNameSubstitutor$LogWrappedImageNameSubstitutor@91aba9e)
	at org.testcontainers.containers.GenericContainer.getDockerImageName(GenericContainer.java:1367)
	at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:362)
	at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:333)
	at io.quarkus.artemis.core.deployment.DevServicesArtemisProcessor.lambda$startArtemis$1(DevServicesArtemisProcessor.java:252)
	at java.base/java.util.Optional.or...

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging-kafka/deployment

✖ io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

• Assertion condition defined as a io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)