Logging with Panache: better failure condition #38528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `Log` API is used inside a Quarkus application, as indicated by presence of `Application.currentApplication()`, all `Log` call sites should be rewritten and hence direct calls to `Log` methods should always fail. Outside of Quarkus, direct calls to `Log` are allowed in tests, as indicated by presence of the JUnit `Assertions` class.
|
I don't know… wouldn't that be true for Quarkus extension runtime code, even though they're not transformed? |
Status for workflow
|
|
@Ladicek is it something we want in 3.7/3.8? If so, it needs the |
|
I treat this as a quality of life improvement and not necessarily a bug fix, so I don't feel like a backport is necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
LogAPI is used inside a Quarkus application, as indicated by presence ofApplication.currentApplication(), allLogcall sites should be rewritten and hence direct calls toLogmethods should always fail. Outside of Quarkus, direct calls toLogare allowed in tests, as indicated by presence of the JUnitAssertionsclass.Follows up on #33210 / #33700.