Simplify Netty unsafe build item configuration for the shaded JCTools queues #38423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… queues GraalVM now seems to have good heuristics to spot the classic Unsafe usage patterns. I removed some UnsafeAccessedFieldBuildItem and added one for UnsafeRefArrayAccess as this class has a problematic static field (REF_ELEMENT_SHIFT). For there record I found about this while working on smallrye/smallrye-mutiny#1434
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. You can consult the Develocity build scans. |
cescoffier
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraalVM now seems to have good heuristics to spot the classic
Unsafeusage patterns.I removed some
UnsafeAccessedFieldBuildItemand added one forUnsafeRefArrayAccessas this class has a problematic static field (REF_ELEMENT_SHIFT).For there record I found about this while working on smallrye/smallrye-mutiny#1434