Fixed deprecation warnings caused by QuarkusPlugin #38249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made sure the sourceSets are created before accessing their configurations.
quarkus-bot
bot
added
area/devtools
ribafish
force-pushed
the
gk/quarkusPluginGradle9Fix
branch
from
a696e0d to
4db15c3
Compare
runningcode
reviewed
Jan 17, 2024
devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/QuarkusPlugin.java
Show resolved
Hide resolved
ribafish
changed the title
aloubyansky
approved these changes
Jan 17, 2024
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. You can consult the Develocity build scans. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed deprecation warnings for Gradle 9 caused by QuarkusPlugin. Made sure the sourceSets are created before accessing their configurations.
Explanation:
Creating configurations that a sourceSet creates is deprecated, resulting in this deprecation warning. Doing it this way will also cause problems when configuration permitted usages are misaligned, resulting in a second deprecation warning.
With the fix applied, custom sourcesets (and their configurations) are created first, then the configurations are configured, after which sourcesets are configured as part of
registerTasksmethod, which also removes the deprecation warnings.