Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] 3.2.10.Final backports batch 1 #38180

Merged
merged 29 commits into from
Jan 16, 2024

Conversation

aloubyansky
Copy link
Member

geoand and others added 28 commits January 14, 2024 22:06
Using an empty string instead of null
is what the classic rest client does,
so let's align with it

Closes: quarkusio#37033
(cherry picked from commit 042aed2)
We need to clean the project before the next compilation as things have
changed a lot (e.g. in the case of a Quarkus 2.x -> 3.x update).

(cherry picked from commit c6ad1fb)
Actually, it was already supported when creating projects, just not when
adding/removing extensions.

Fixes quarkusio#37564

(cherry picked from commit 09d2c52)
…thentication-tutorial.adoc

(cherry picked from commit 5545a2b)
Copy link

quarkus-bot bot commented Jan 14, 2024

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/docstyle issues related for manual docstyle review area/documentation area/gradle Gradle area/hibernate-orm Hibernate ORM area/keycloak area/panache area/persistence OBSOLETE, DO NOT USE area/platform Issues related to definition and interaction with Quarkus Platform area/rest area/spring Issues relating to the Spring integration area/tracing area/vertx labels Jan 14, 2024
Copy link

github-actions bot commented Jan 14, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@rsvoboda
Copy link
Member

I think extensions/resteasy-reactive/rest-client-reactive/runtime failure could be avoided after backporting of a71f2dc
@gsmet do you have other tips?

This comment has been minimized.

Unfortunately, using @tempdir on Windows CI is not working very well and
this test has been failing from time to time for a few days now.

Applying the same trick as in quarkusio#31996

This comment has been minimized.

Copy link

quarkus-bot bot commented Jan 16, 2024

Failing Jobs - Building 2e4648b

Status Name Step Failures Logs Raw logs Build scan
✔️ Gradle Tests - JDK 11 🚧
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs 🚧

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.CustomManifestArgumentsTest.shouldContainsSpecificManifestProperty line 37 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual not to be null
	at io.quarkus.gradle.CustomManifestArgumentsTest.shouldContainsSpecificManifestProperty(CustomManifestArgumentsTest.java:37)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)

@rsvoboda
Copy link
Member

@aloubyansky #37038 is another PR to backport

CustomManifestArgumentsTest is disabled on Windows in main

@aloubyansky
Copy link
Member Author

I'll include that one in the next batch @rsvoboda

@aloubyansky aloubyansky merged commit c36ab69 into quarkusio:3.2 Jan 16, 2024
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cache area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/docstyle issues related for manual docstyle review area/documentation area/gradle Gradle area/hibernate-orm Hibernate ORM area/keycloak area/panache area/persistence OBSOLETE, DO NOT USE area/platform Issues related to definition and interaction with Quarkus Platform area/rest area/spring Issues relating to the Spring integration area/tracing area/vertx
Projects
Development

Successfully merging this pull request may close these issues.