Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail testCallBackContextIsNotFailed on aborted tests #38115

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Jan 10, 2024

As seen in #37809 testCallBackContextIsNotFailed fails when other tests get aborted due to a failing assumption, e.g. in

This happens because test failures are recorded in the test's extension context through io.quarkus.test.junit.AbstractQuarkusTestWithContextExtension and are then seen by io.quarkus.it.main.QuarkusTestCallbacksITCase#testCallbackContextIsNotFailed which checks to see the test status of the context in

assertFalse(TestContextCheckerBeforeEachCallback.CONTEXT.getTestStatus().isTestFailed());

This is a naive fix that doesn't treat TestAbortedExceptions as failures for the said test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant