Don't fail testCallBackContextIsNotFailed on aborted tests #38115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in #37809
testCallBackContextIsNotFailed
fails when other tests get aborted due to a failing assumption, e.g. inquarkus/test-framework/junit5/src/main/java/io/quarkus/test/junit/nativeimage/NativeBuildOutputExtension.java
Line 54 in 21f055a
This happens because test failures are recorded in the test's extension context through
io.quarkus.test.junit.AbstractQuarkusTestWithContextExtension
and are then seen byio.quarkus.it.main.QuarkusTestCallbacksITCase#testCallbackContextIsNotFailed
which checks to see the test status of the context inquarkus/integration-tests/main/src/test/java/io/quarkus/it/main/QuarkusTestCallbacksITCase.java
Line 61 in 1ed54f0
This is a naive fix that doesn't treat
TestAbortedException
s as failures for the said test.