Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arc - Decide whether req. context is active based on validity of its ContextState #38107

Merged
merged 1 commit into from
Jan 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
package io.quarkus.vertx.http.router;

import static org.hamcrest.Matchers.is;

import jakarta.enterprise.event.Observes;
import jakarta.inject.Singleton;

import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.RegisterExtension;

import io.quarkus.arc.Arc;
import io.quarkus.runtime.StartupEvent;
import io.quarkus.test.QuarkusUnitTest;
import io.restassured.RestAssured;
import io.vertx.ext.web.Router;

/**
* Test is located here so that {@code VertxCurrentContextFactory} is used within req. context implementation.
* See also https://github.com/quarkusio/quarkus/issues/37741
*/
public class ReqContextActivationTerminationTest {

@RegisterExtension
static final QuarkusUnitTest config = new QuarkusUnitTest()
.withApplicationRoot((jar) -> jar.addClasses(BeanWithObserver.class));

@Test
public void testRoute() {
RestAssured.when().get("/boom").then().statusCode(200).body(is("ok"));
}

@Singleton
public static class BeanWithObserver {

private static int counter;

void observeRouter(@Observes StartupEvent startup, Router router) {
router.get("/boom").handler(ctx -> {
// context starts as inactive; we perform manual activation/termination and assert
Assertions.assertEquals(false, Arc.container().requestContext().isActive());
Arc.container().requestContext().activate();
Assertions.assertEquals(true, Arc.container().requestContext().isActive());
Arc.container().requestContext().terminate();
Assertions.assertEquals(false, Arc.container().requestContext().isActive());
ctx.response().setStatusCode(200).end("ok");
});
}

}
}
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@ public <T> T get(Contextual<T> contextual) {

@Override
public boolean isActive() {
return currentContext.get() != null;
RequestContextState requestContextState = currentContext.get();
return requestContextState == null ? false : requestContextState.isValid();
Copy link
Contributor

@franz1981 franz1981 Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, the only downside is the dependent load, but having a volatile load is pretty cheap on most architecture, and regardless... there is not much to do here, given that we requires correctness first!

}

@Override
Expand Down
Loading