Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Create the Maven project section in security-oidc-bearer-token-authentication-tutorial.adoc #37975

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Fix Create the Maven project section in security-oidc-bearer-token-authentication-tutorial.adoc #37975

merged 1 commit into from
Jan 2, 2024

Conversation

sberyozkin
Copy link
Member

Fixes #37973.

This PR fixes 2 issues mentioned in #37973:

  • Extensions are now correctly shown when a new project is created
  • Fixes the empty Gradle command when adding an extension to the existing project, and also makes it consistent with how it is shown in the OIDC code flow guide

@sberyozkin sberyozkin requested a review from rsvoboda January 2, 2024 11:24
@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Jan 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2024 •
edited
Loading

🙈 The PR is closed and the preview is expired.

rsvoboda
rsvoboda approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New version looks nicer than the original https://quarkus.io/guides/security-oidc-bearer-token-authentication-tutorial

@rsvoboda rsvoboda merged commit 7c70516 into quarkusio:main Jan 2, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Jan 2, 2024
@gsmet
Copy link
Member

gsmet commented Jan 9, 2024

This is not backportable due to too many changes in this area.

@aloubyansky aloubyansky modified the milestones: 3.7 - main, 3.2.10.Final Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsvoboda rsvoboda rsvoboda approved these changes

Assignees
No one assigned
Labels
area/docstyle issues related for manual docstyle review area/documentation kind/bugfix
Projects
Quarkus Documentation
Status: Done
Milestone
3.2.10.Final
Development

Successfully merging this pull request may close these issues.

create-app-extensions macro does not work in security-oidc-bearer-token-authentication-tutorial
4 participants
@sberyozkin @gsmet @rsvoboda @aloubyansky