-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vertx to 4.5.1 #37864
Update vertx to 4.5.1 #37864
Conversation
Will also close #36691 (eclipse-vertx/vertx-grpc#83) |
🙈 The PR is closed and the preview is expired. |
396f259
to
7e00564
Compare
The Vertx upgrades is something that @cescoffier handles as it requires extreme caution, knowledge of both Quarkus and Vertx internals and the broader reactive dependencies impact. I'll let him decide, but I'm pretty sure we're going to close this one |
This version of vertx contains breaking changes and typically break reactive messaging, Quarkus http and the rest client. I will take care of this in January. |
You also need to bump Netty at the same time. |
Good, thanks for the info @cescoffier. Please let me know if there is any way I can help as it's causing quite some noise in our CI runs with Mandrel 24.0-dev. |
It would be interesting to just bump Netty in a PR to see how it goes (without Vert.x) |
Thanks for the heads up @jdussouillez |
Closes #37208
Draft till CI completes in my fork https://github.com/zakkak/quarkus/actions/runs/7275037360