Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Maven Compiler Plugin 3.12.1 #37842

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Dec 19, 2023

Unfortunately, we can't integrate it for now as we are hit by https://issues.apache.org/jira/browse/MCOMPILER-567.

@gsmet
Copy link
Member Author

gsmet commented Dec 19, 2023

/cc @yrodiere

@quarkus-bot quarkus-bot bot added area/amazon-lambda area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/funqy area/maven area/platform Issues related to definition and interaction with Quarkus Platform labels Dec 19, 2023
@jorsol
Copy link
Contributor

jorsol commented Dec 20, 2023

A patch release (3.12.1) might be available in the coming weeks.

@gsmet
Copy link
Member Author

gsmet commented Dec 20, 2023

@jorsol yeah, I saw you were working hard on that, thanks!

@jorsol
Copy link
Contributor

jorsol commented Dec 24, 2023

@gsmet m-compiler-p 3.12.1 is now available!

@gsmet gsmet force-pushed the maven-compiler-plugin-3.12.0 branch from e3637fb to da80f82 Compare January 3, 2024 14:20
@gsmet gsmet changed the title Upgrade to Maven Compiler Plugin 3.12.0 Upgrade to Maven Compiler Plugin 3.12.1 Jan 3, 2024
@gsmet
Copy link
Member Author

gsmet commented Jan 3, 2024

Adjusted to target 3.12.1.

@gsmet gsmet marked this pull request as ready for review January 3, 2024 14:21
@gsmet
Copy link
Member Author

gsmet commented Jan 3, 2024

@jorsol thanks! I just got back from PTO and updated the PR.

Copy link

github-actions bot commented Jan 3, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@famod
Copy link
Member

famod commented Jan 4, 2024

FYI, this depMgmt version lookup does not seem to support relocations: apache/maven-compiler-plugin#180 (comment)

Edit: I probably should have posted this in #37477 instead. cc @yrodiere

@gsmet gsmet force-pushed the maven-compiler-plugin-3.12.0 branch from da80f82 to 7ab7d04 Compare January 5, 2024 15:58
Copy link

quarkus-bot bot commented Jan 5, 2024

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet requested a review from geoand January 5, 2024 18:25
@gsmet gsmet merged commit e23f243 into quarkusio:main Jan 5, 2024
53 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/amazon-lambda area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/funqy area/maven area/platform Issues related to definition and interaction with Quarkus Platform
Projects
Development

Successfully merging this pull request may close these issues.

4 participants