-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keycloak docs fix wrong link and add small enhancement #37748
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,7 +32,7 @@ | |
:prerequisites-docker: | ||
include::{includes}/prerequisites.adoc[] | ||
* https://stedolan.github.io/jq/[jq tool] | ||
* https://www.keycloak.org/docs/latest/server_installation/index.html[Keycloak] | ||
* https://www.keycloak.org[Keycloak] | ||
|
||
== Architecture | ||
|
||
|
@@ -115,7 +115,7 @@ | |
import jakarta.ws.rs.GET; | ||
import jakarta.ws.rs.Path; | ||
|
||
import org.jboss.resteasy.annotations.cache.NoCache; | ||
import org.jboss.resteasy.reactive.NoCache; | ||
|
||
import io.quarkus.security.identity.SecurityIdentity; | ||
|
||
|
@@ -210,9 +210,9 @@ | |
docker run --name keycloak -e KEYCLOAK_ADMIN=admin -e KEYCLOAK_ADMIN_PASSWORD=admin -p 8543:8443 -v "$(pwd)"/config/keycloak-keystore.jks:/etc/keycloak-keystore.jks quay.io/keycloak/keycloak:{keycloak.version} start --hostname-strict=false --https-key-store-file=/etc/keycloak-keystore.jks | ||
---- | ||
|
||
where `keycloak.version` should be set to `17.0.0` or higher. | ||
where `keycloak.version` should be set to `23.0.0` or higher and the `keycloak-keystore.jks` can be found in https://github.com/quarkusio/quarkus-quickstarts/blob/main/security-keycloak-authorization-quickstart/config/keycloak-keystore.jks[quarkus-quickstarts/security-keycloak-authorization-quickstart/config] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please don't use direct links, use variables instead: |
||
|
||
You should be able to access your Keycloak Server at https://localhost:8543[localhost:8543]. | ||
Check warning on line 215 in docs/src/main/asciidoc/security-keycloak-authorization.adoc GitHub Actions / Linting with Vale
|
||
|
||
Log in as the `admin` user to access the Keycloak Administration Console. | ||
Username should be `admin` and password `admin`. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users are not expected to use it somehow, the command above picks it up with
"$(pwd)"/config/keycloak-keystore.jks
, so it is not clear what adding this information helps with, alongside a more important KC version update infoThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My point in here is that if user not using quickstart but go through this by him self. He can easily miss this. I can drop it if you stand on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jedla97 Sure, makes sense to keep it, thanks