-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add apicurio jsonserde support #37722
Add apicurio jsonserde support #37722
Conversation
54da4ce
to
d9490e1
Compare
99d4de1
to
60992ca
Compare
@cescoffier do you mind approving the CI run? I have the quickstart ready locally and the tests passing for native as well. |
This comment has been minimized.
This comment has been minimized.
0892fe3
to
f412e69
Compare
@carlesarnal hey, thanks for this PR. Ideally, make sure CI passes in your fork before we approve the CI run here. Also, probably a good idea to squash the commits to be a bit more semantic. Not sure if you need one big one or several ones but we don't need to see all the small iterations. Thanks! |
Hey, yes, I realised now that the CI jobs are running on my fork, I'll make sure they pass there and squash the commits, tyvm. |
cd67477
to
61c1919
Compare
61c1919
to
f7f7268
Compare
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
f7f7268
to
aa7b2bd
Compare
@gsmet all the tests are green on my fork except for the JVM 17 on Windows that, for some reason cannot find a valid docker env. Any hint on what might be happening? |
aa7b2bd
to
12c13a3
Compare
Ok, I might have figured out the reason, I was defaulting the test execution to true no matter the profile, I have changed the default values appropriately, let's see what CI has to say, sorry about the noise. |
@cescoffier at your convenience, CI on my fork is green, including native tests etc, so this is ready for your review. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It would be great to:
- implement serde discovery if possible (not totally sure it it possible)
- Make sure native is working as expected.
...ema-registry/apicurio/json-schema/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Show resolved
Hide resolved
|
This comment has been minimized.
This comment has been minimized.
Failing Jobs - Building bbee606
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 21 #- Failing: extensions/scheduler/deployment
! Skipped: extensions/quartz/deployment extensions/spring-scheduled/deployment integration-tests/main and 7 more 📦 extensions/scheduler/deployment✖
|
This PR includes the initial support for json schema serialization using Apicurio Registry serdes. For now, autodiscovery of the channel and appropriate serde is not possible, so it must be manually configured.