Workaround DateTimeParseException in vertx-sql-client with JDK 22 #37683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for quarkusio#37208 till eclipse-vertx/vertx-sql-client#1379 gets fixed and released Note that the substitution only happens if necessary (i.e. it won't happen when using JDK < 22, and it won't happen once an upstream fix becomes available. Closes quarkusio#37208
|
@jerboaa could you please review this? |
|
Unfortunately it doesn't work without loading the class at some point (I mistakenly tested it locally with Mandrel 23.1.1 instead of 24.0-dev) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #37208 till eclipse-vertx/vertx-sql-client#1379 gets fixed and released
Note that the substitution only happens if necessary (i.e. it won't
happen when using JDK < 22, and it won't happen once an upstream fix
becomes available.
Closes #37208
CI run testing this against Mandrel 24.0-dev based on JDK 22-ea: https://github.com/graalvm/mandrel/actions/runs/7178673001