Netty PlatformDependent0.<init> uses DirectByteBuffer reflectively
#37628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we moved `io.netty.util.internal.PlatformDependent`'s and `io.netty.util.internal.PlatformDependent0`' initialization at runtime we need to register `java.nio.DirectByteBuffer`'s constructors for reflective access to avoid miss-configurations due to not being able to access the constructor in https://github.com/netty/netty/blob/5db037beedca8aa5b6a486fa515cc6af013ced74/common/src/main/java/io/netty/util/internal/PlatformDependent0.java#L290-L292 More classes and methods need to be registered as discussed in quarkusio#37626 Closes Karm/mandrel-integration-tests#236
|
FWIW setting See Karm/mandrel-integration-tests#236 (comment) Interestingly DirectByteBuffer's constructor is not reachable in JVM-mode, but it doesn't seem to cause any issues: and the reason is that "Reflective setAccessible(true)" is disabled, which is what I would expect |
|
Switching to draft since I need to better understand what's going on. |
zakkak
added a commit
to zakkak/quarkus
that referenced
this pull request
Dec 8, 2023
In quarkusio#37347 we moved `PlatformDependent` and `PlatformDependent0` classes to run-time-initialization as they are platform-dependent and thus need to be initialized on the target platform. It looks like there are more classes like these that need to be runtime initialized as they transitively rely on platform dependent values. Closes Karm/mandrel-integration-tests#236 Supersedes quarkusio#37628
|
Superseded by #37633 |
zakkak
added a commit
to zakkak/quarkus
that referenced
this pull request
Dec 11, 2023
In quarkusio#37347 we moved `PlatformDependent` and `PlatformDependent0` classes to run-time-initialization as they are platform-dependent and thus need to be initialized on the target platform. It looks like there are more classes like these that need to be runtime initialized as they transitively rely on platform dependent values. Closes Karm/mandrel-integration-tests#236 Supersedes quarkusio#37628
zakkak
deleted the
2023-12-08-fix-netty-platform-dependent-run-time-init
branch
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this pull request
Jan 15, 2024
In quarkusio#37347 we moved `PlatformDependent` and `PlatformDependent0` classes to run-time-initialization as they are platform-dependent and thus need to be initialized on the target platform. It looks like there are more classes like these that need to be runtime initialized as they transitively rely on platform dependent values. Closes Karm/mandrel-integration-tests#236 Supersedes quarkusio#37628 (cherry picked from commit 72d7b79)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we moved
io.netty.util.internal.PlatformDependent's andio.netty.util.internal.PlatformDependent0' initialization at runtime we need to registerjava.nio.DirectByteBuffer's constructors for reflective access to avoid miss-configurations due to not being able to access the constructor inhttps://github.com/netty/netty/blob/5db037beedca8aa5b6a486fa515cc6af013ced74/common/src/main/java/io/netty/util/internal/PlatformDependent0.java#L290-L292
More classes and methods might need to be registered as discussed in #37626
Closes Karm/mandrel-integration-tests#236
Note this is not a complete fix for #37626, it only partially solves the problem and unblocks our (mandrel team) CI.