-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit Dev Services and UI for OIDC #37566
Conversation
@sberyozkin You're welcome to question or push back on any of the proposed changes.
I noticed that, in the text, the labels of some UI elements such as button labels in the text didn't match the labels in the images. I revised the text to match the the images. This might be wrong and we might need to update the images to match the text instead. For example:
|
🙈 The PR is closed and the preview is expired. |
@sberyozkin Some other changes you might notice:
I'll be happy to explain or simply reverse any changes (or types or changes) that you request. |
ed133d8
to
eeae52f
Compare
docs/src/main/asciidoc/security-openid-connect-dev-services.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect cleanup, @rolfedh, thanks, a couple of minor suggestions is proposed
Thanks again, @sberyozkin. I've applied your suggestions. I believe this PR is ready for merge. |
6552ae3
to
4b0f7e2
Compare
@rolfedh: I completed peer review with some comments for your consideration - mainly some capitalization/terminology questions, for example "Dev Services for Keycloak" and also some queries on some text ambiguities. |
docs/src/main/asciidoc/security-openid-connect-dev-services.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-dev-services.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-dev-services.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-dev-services.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-dev-services.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-dev-services.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-dev-services.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-dev-services.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-dev-services.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-dev-services.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-client-reference.adoc
Outdated
Show resolved
Hide resolved
@sheilamjones, @sberyozkin: I've applied Sheila's suggestions to the file. If you both approve, this PR should be ready to merge. |
docs/src/main/asciidoc/security-openid-connect-dev-services.adoc
Outdated
Show resolved
Hide resolved
Hi @sberyozkin. I believe this is ready for merge. |
Thanks @rolfedh |
Edit Dev Services and UI for OIDC
Edit Dev Services and UI for OIDC
Purpose: Edit the "Dev Services and Dev UI for OpenID Connect (OIDC)" guide.
References: QDOCS-555