-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Produce a 503 response when there no more worker threads to handle blocking requests #36869
Conversation
I tested it manually. I didn't want to implement a test as it was going to be flaky. You need to overload the server, and on GH actions this is The code is self-explanatory. |
@cescoffier - I see a Besides that, I've reviewed it in the context of Keycloak, and the solution should work fine handling the exception thrown using RESTEasy reactive. |
The exception is not handled in RestEasy reactive, but at the vertx http level directly. Thus it will work with RestEasy classic, reactive routes, gRPC... |
System.out removed. |
@cescoffier - let me rephrase my previous statement: "The solution you are presenting here looks good and will work fine with Keycloak's use of RestEasy reactive". The only reason I used "should" was that I was just debugging the code, and not testing a full backport of change with Keycloak. Sorry for the confusion. So TL;DR: This solution is fine for Keycloak |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Fix #36860