Tiny Vale tweaks for Datasource and Logging guide #36837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/docstyle
MichalMaler
force-pushed
the
Tiny-Vale-tweaks
branch
from
646f0c2 to
70aeeda
Compare
jmartisk
requested changes
Nov 2, 2023
Ladicek
reviewed
Nov 2, 2023
|
LGTM, just one comment/question. |
|
🎊 PR Preview 389a663 has been successfully built and deployed to https://quarkus-pr-main-36837-preview.surge.sh/version/main/guides/ |
Signed-off-by: Michal Maléř <[email protected]>
MichalMaler
force-pushed
the
Tiny-Vale-tweaks
branch
from
70aeeda to
f9c52c0
Compare
yrodiere
approved these changes
Nov 2, 2023
yrodiere
added
the
triage/waiting-for-ci
jmartisk
approved these changes
Nov 2, 2023
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some tiny cosmetics that support the great effort of @michelle-purcell who incorporates all other writer's feedback on Vale behavior and its follow-up improvisation.