Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assertions in Hibernate ORM 5.6 compatibility tests #36802

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fix assertions in Hibernate ORM 5.6 compatibility tests #36802

merged 1 commit into from
Oct 31, 2023

Conversation

yrodiere
Copy link
Member

Fixes #36794

@yrodiere
Fix assertions in Hibernate ORM 5.6 compatibility tests
bedb7b1 
Hibernate ORM 5.6 does not, in fact, preserve information for OffsetTime
columns. It just slaps the current JVM timezone on a stored LocalTime.
@yrodiere yrodiere requested a review from rsvoboda October 31, 2023 15:16
@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Oct 31, 2023
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Oct 31, 2023

/cc @Sanne (hibernate-orm), @gsmet (hibernate-orm)

@yrodiere
Copy link
Member Author

I also changed the date on my local computer, to check that this will work after the next DST switch. Tests passed.

BTW, I do not recommend setting the date of your computer to something 6 months in the future. My system went crazy with warnings about expired SSL certificates all around. Not fun.

@yrodiere yrodiere mentioned this pull request Oct 31, 2023
Merged
40 tasks
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Oct 31, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@yrodiere
Copy link
Member Author

Wow, that must be the fastest Quarkus CI run I've ever seen. I checked just in case, and the previously failing tests were actually run, and passed.

Now I just need an approval to merge... @rsvoboda?

rsvoboda
rsvoboda approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, checked locally and tests passed.

@rsvoboda rsvoboda merged commit 72e99a3 into quarkusio:main Oct 31, 2023
19 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 31, 2023
@rsvoboda
Copy link
Member

Wow, that must be the fastest Quarkus CI run I've ever seen.

Yeah, your change is located just in one module which is also not used by anything else :)

@aloubyansky aloubyansky modified the milestones: 3.6 - main, 3.2.8.Final Oct 31, 2023
@yrodiere yrodiere deleted the fix-orm-5.6-timezone branch January 29, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsvoboda rsvoboda rsvoboda approved these changes

Assignees
No one assigned
Labels
area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE kind/bugfix
Projects
None yet
Milestone
3.2.8.Final
Development

Successfully merging this pull request may close these issues.

hibernate-orm-compatibility-5.6 tests are failing on CompatibilityTest.offsetTime
4 participants
@yrodiere @rsvoboda @aloubyansky @gsmet