-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove type from ResolverMapKey #36719
Remove type from ResolverMapKey #36719
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense!
@geoand I have found the cause of the why the I have added a second commit to get your opinion. I can adjust / squash if you find it is ok.
Thank you. |
Makes sense, thanks! |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Milestone is already set for some of the items: We haven't automatically updated the milestones for these items. This message is automatically generated by a bot. |
This is an attempt to fix #36067. The reproducer can still reproduce the issue by using different "types". Since the object mapper is per restclient, it should apply to any types used within it. The types should I believe not be checked.
With this attempt, the reproducer goes from 7 invocations to 2. I would appreciate help on finding out why it is still called twice.
reproducer: https://github.com/manofthepeace/quarkus-restclient-annotations-issue
Note: the type parameter is passed in a method chain that could potentially be cleaned up is this is the right approach, which I am not sure.
cc @geoand
many thanks,
Alex