Remove unconfigured datasource

[jtama]

Fixes #36666

[quarkus-bot]

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

• title should not end up with dot

_{This message is automatically generated by a bot.}

[jtama]

So I manually dispatched the build but it skipped everything. Don't know why. And my laptop is dying so I can't build all quarkus ;)

[yrodiere]

So I manually dispatched the build but it skipped everything. Don't know why. And my laptop is dying so I can't build all quarkus ;)

The workflow ignores the main branch in forks, don't ask me why. You need to work in a branch that is not named main...

[jtama]

So I had to amend hibernate extension that had to explicitely take care of UnconfiguredDataSource.

[yrodiere]

@jtama I think your build is still failing? https://github.com/jtama/remove-unconfigured-data-source/actions/runs/6649954232/job/18069255620

See https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#ide-config-and-code-style

[jtama]

@jtama I think your build is still failing? https://github.com/jtama/remove-unconfigured-data-source/actions/runs/6649954232/job/18069255620

See https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#ide-config-and-code-style

Yes indeed I did spoke to quickly. Fixing all this and now correcting the real errors which are for the moment, extension that needed to explicitly handle unconfigured datasources as error cases...

[yrodiere]

Yes indeed I did spoke to quickly. Fixing all this and now correcting the real errors which are for the moment, extension that needed to explicitly handle unconfigured datasources as error cases...

Maybe we should list those and discuss this more widely before you spend too much time on it, as we're not sure yet this is the right approach... please ping me when you get a full build listing all errors.

[jtama]

@yrodiere I have this https://github.com/jtama/remove-unconfigured-data-source/actions/runs/6651810790

[yrodiere]

Looking at the tests, I realized that this removal of UnconfiguredDatasource is hitting a few problems because "deactivating" datasources is sometimes necessary, but the only way we provide to do this is implicit, by not providing connection info.

I'll try to implement a way to explicitly "deactivate" a datasource through a configuration property as discussed on quarkus-dev, and will send a PR. We'll see where this leads us.

Thanks for the initial investigation @jtama!

[yrodiere]

See also #37265