Fix quarkus update regression on extensions

[ia3andy]

This commit e9006c1, changed the logic when running update to allow having the update info as a data structure.

The checks added when building the structure were the same as when logging the info to update which is a bit too restrictive as it prevented from updating extensions.

[ia3andy]

@aloubyansky with this PR (and before the data structure update) when running udpate on an extension we had this log:

~/S/u/quarkus-github-app> mvn io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:update -e                                                                                         try?
[INFO] Error stacktraces are turned on.
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] Quarkus - GitHub App - Parent                                      [pom]
[INFO] Quarkus - GitHub App - Events                                      [jar]
[INFO] Quarkus - GitHub App - Runtime                                     [jar]
[INFO] Quarkus - GitHub App - Deployment                                  [jar]
[INFO] Quarkus - GitHub App - Command Airline                             [pom]
[INFO] Quarkus - GitHub App - Command Airline - Runtime                   [jar]
[INFO] Quarkus - GitHub App - Command Airline - Deployment                [jar]
[INFO] Quarkus - GitHub App - Testing                                     [jar]
[INFO] Quarkus - GitHub App - Integration Tests                           [pom]
[INFO] Quarkus - GitHub App - Integration Tests - Testing Framework       [jar]
[INFO] Quarkus - GitHub App - Integration Tests - App                     [jar]
[INFO] Quarkus - GitHub App - Integration Tests - Command Airline         [jar]
[INFO] Quarkus - GitHub App - Documentation                               [jar]
[INFO]
[INFO] ---------< io.quarkiverse.githubapp:quarkus-github-app-parent >---------
[INFO] Building Quarkus - GitHub App - Parent 1.17.1                     [1/13]
[INFO]   from pom.xml
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- quarkus:999-SNAPSHOT:update (default-cli) @ quarkus-github-app-parent ---
[WARNING] quarkus:update goal is experimental, its options and output might change in future versions
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-devtools-base-codestarts/999-SNAPSHOT/maven-metadata.xml
[INFO] Detected project Java version: 11
[INFO] Detected project Java version: 11
[INFO] Instructions to update this project from '2.16.6.Final' to '3.4.3':
[INFO] No Quarkus extensions were found among the project dependencie
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-update-recipes/maven-metadata.xml
Downloading from mvnpm.org: https://repo.mvnpm.org/maven2/io/quarkus/quarkus-update-recipes/maven-metadata.xml
Downloaded from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-update-recipes/maven-metadata.xml (618 B at 2.5 kB/s)
[INFO] Resolved io.quarkus:quarkus-updates-recipes:1.0.4 with 4 recipe(s) to update from 2.16.6.Final to 3.4.3 (initially made for OpenRewrite MAVEN plugin version: 4.46.0)
[INFO] OpenRewrite recipe generated: /var/folders/j8/sj85tl7d2pq_vnhbpj4t5lwm0000gn/T/quarkus-project-recipe-10894293312427810623.yaml

as you can see there are not instructions to update the project bom, is that normal?

[quarkus-bot]

Failing Jobs - Building 2f453f4

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✖	JVM Tests - JDK 11	Build	⚠️ Check →	Logs	Raw logs
✖	JVM Tests - JDK 17	Build	Failures	Logs	Raw logs
✖	JVM Tests - JDK 17 Windows	Build	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 21
✔️	Maven Tests - JDK 11
✖	Maven Tests - JDK 11 Windows	Build	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/kubernetes-client-devservices 

📦 integration-tests/kubernetes-client-devservices

✖ io.quarkus.kubernetes.client.devservices.it.DevServicesKubernetesITest.shouldReturnAllKeys - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.kubernetes.client.deployment.DevServicesKubernetesProcessor#setupKubernetesDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image k8s.gcr.io/kube-apiserver:v1.24.1

---

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/vertx-http/deployment 
! Skipped: devtools/cli extensions/agroal/deployment extensions/amazon-lambda-http/deployment and 364 more

📦 extensions/vertx-http/deployment

✖ io.quarkus.vertx.http.proxy.TrustedForwarderProxyFailureTest.testHeadersAreIgnored line 29 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:288)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:314)

✖ io.quarkus.vertx.http.proxy.TrustedXForwarderProxiesUnknownHostnameFailureTest.testHeadersAreIgnored line 17 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:288)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:314)

---

⚙️ Maven Tests - JDK 11 Windows #

- Failing: integration-tests/maven 

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

[gsmet]

Thanks for the quick turnaround.

[gsmet]

@rsvoboda @aloubyansky note that this is important to backport or people will have trouble updating their custom extensions.