Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuarkusSecurityTestExtension afterEach call should not be made for tests without @TestSecurity #36645

Merged

Conversation

sberyozkin
Copy link
Member

Fixes #36601

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 23, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@sberyozkin
Copy link
Member Author

Thanks @manovotn and thanks @Ladicek for explaining how to fix it

@sberyozkin sberyozkin merged commit 13ba9d0 into quarkusio:main Oct 23, 2023
23 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 23, 2023
@sberyozkin sberyozkin deleted the security_test_extension_after_each_fix branch October 23, 2023 22:13
@gsmet gsmet modified the milestones: 3.6 - main, 3.5.1 Oct 26, 2023
@aloubyansky aloubyansky modified the milestones: 3.5.1, 3.2.8.Final Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuarkusSecurityTestExtension should not call CDI.current() when annotation is not present.
4 participants