Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vert.x to 4.4.6 #36502

Closed
wants to merge 1 commit into from
Closed

Conversation

bartm-dvb
Copy link
Contributor

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/vertx labels Oct 16, 2023
- Fixes Redis connection pooling for quarkusio#36382
@gsmet
Copy link
Member

gsmet commented Oct 17, 2023

Thanks but Vert.x updates are usually a bit harder than that as it's a core component and we might need to release other components :).

@cescoffier my understanding is that you will need to coordinate this one with other releases?

@bartm-dvb
Copy link
Contributor Author

Thanks but Vert.x updates are usually a bit harder than that as it's a core component and we might need to release other components :).

@cescoffier my understanding is that you will need to coordinate this one with other releases?

Alright, I was suspecting that would be the case but I was willing to give it a try anyway. You can close this PR if it will be picked up by the maintainers.

@cescoffier
Copy link
Member

Yes, it's a lot more compiicated, and our upgrade must be backportable too.

In general, it requires:

  • updating the Mutiny bindings and verifying breaking changes
  • updating reactive messaging
  • updating stork
  • updating quarkus HTTP
  • finally, updating quarkus
  • expose new config in quarkus and extend documentation
  • verify the issues that were potentially fixed in vert.x

I will try to start the process this week. However, it takes several days of work.

@cescoffier cescoffier closed this Oct 17, 2023
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Oct 17, 2023
@ahus1
Copy link
Contributor

ahus1 commented Oct 18, 2023

Upcoming PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/vertx triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants