Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC Db Token State Manager - disable MSSQL test due to limited Github CI resources and cancel timer on shutdown #36366

Conversation

michalvavrik
Copy link
Member

  • Introduce OIDC Database Token State Manager extension #36175 (review) suggested to cancel timer on shutdown, the bean is dependent (which feels right as there is no good reason to keep it after events are resolved), so I saved it in static property
  • Check semicolon during the OIDC scope to permission conversion #36361 (comment) showed tests are flaky in Github CI; I played with these tests quite a while and can't see anything wrong. The test failed with Keycloak server is not available: Retries exhausted : 5 attempts against 1696866807307/1696866807257 expiration [Error Occurred After Shutdown]. It seems like in Github CI runners don't have sufficient resources. I'm still convinced we should run as much tests as possible (that's why I'm only disabling the one that failed), but can't simply add more space. I think we need to go back to it.

@quarkus-bot quarkus-bot bot added the area/oidc label Oct 9, 2023
@michalvavrik michalvavrik changed the title OIDC Db Token State Man - disable MSSQL test due to limited Github CI resources and cancel timer on shutdown OIDC Db Token State Manager - disable MSSQL test due to limited Github CI resources and cancel timer on shutdown Oct 9, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 9, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@sberyozkin sberyozkin merged commit f64aaf4 into quarkusio:main Oct 9, 2023
19 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Oct 9, 2023
@michalvavrik michalvavrik deleted the feature/ref-oidc-db-token-state-manager branch October 10, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants