Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain how to deal with Rate Limiting in the OIDC providers doc #36362

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

sberyozkin
Copy link
Member

Many social OAuth2 providers which Quarkus will keep requesting to fetch UserInfo can be very restrictive so caching UserInfo is a way to manage such rate limiting policies.

PR also fixes another Mastodon text typo (George, I was too petrified to open a dedicated PR to fix it after spotting it shortly after fixing the image name typo :-) )

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, suggested some minor rewording, see if that makes sense

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, suggested some minor rewording, see if that makes sense

@sberyozkin
Copy link
Member Author

Thanks @gastaldi for improving the text, laptop is in the office so I'll squash tomorrow, cheers

@sberyozkin sberyozkin force-pushed the oidc_providers_rate_limiting branch from ad2580b to 01a847a Compare October 10, 2023 09:38
@sberyozkin
Copy link
Member Author

I tried to cancel the doc workflow for now

@sberyozkin sberyozkin force-pushed the oidc_providers_rate_limiting branch from 01a847a to 9f95033 Compare October 10, 2023 12:56
@sberyozkin
Copy link
Member Author

Strange failure in the doc component:

Error:  Failed to execute goal uk.co.automatictester:truststore-maven-plugin:3.0.0:generate-truststore (self-signed-truststore) on project quarkus-integration-test-rest-client: Execution self-signed-truststore of goal uk.co.automatictester:truststore-maven-plugin:3.0.0:generate-truststore failed: Unable to establish TLS connection with: self-signed.badssl.com:443 -> [Help 1]

@sberyozkin sberyozkin force-pushed the oidc_providers_rate_limiting branch from 9f95033 to ea8b5f6 Compare October 10, 2023 16:25
@github-actions
Copy link

github-actions bot commented Oct 10, 2023

🙈 The PR is closed and the preview is expired.

@sberyozkin sberyozkin merged commit d0a01c5 into quarkusio:main Oct 10, 2023
5 checks passed
@sberyozkin sberyozkin deleted the oidc_providers_rate_limiting branch October 10, 2023 17:17
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants