Fix some typos on code and javadoc on maven devtool project

[bmscomp]

This pull request is to fix some typos on java doc and java method name and some minor cleanup

• fix typo on java doc
• fix typo in java method getProjectDeployer
• remove unnecessary final keyword on static method
• favorite the usage of method reference over lambda expression

[gsmet]

Most of the changes are for the better, thanks! But I have a question on one of them.

[gsmet]

Could you explain this particular change?

[bmscomp]

Thanks so much @gsmet for the review, I can say that Result of 'e.equals(n)' is always 'false' for the reason that ‘equals' between objects of inconvertible types 'Deployer' and 'String’, So I made this shortcut

I think this class deserves to write a test for it’s own

Please let me know if I missed something with that, I can rollback this change the time to have some tests for Deployer enum

[gsmet]

Hum. This is a bug, and not a pretty one. I recommend you keep it the way it is for now (i.e. get back to the previous buggy behavior) and we will address it in a follow-up PR as we need to discuss it.

@iocanel I think you wanted to either compare with e.name() or e.extension. I'm not completely sure about the fix as I'm a bit unsure of how you handle knative. I don't see an extension for it so I suppose you would have kubernetes instead and that knative can't really be identified this way?

If so, it might be better to drop .map(d -> strip(d.getArtifactId())) entirely and compare on the extension rather than the name.

I will let you have a look.

[bmscomp]

@gsmet, @iocanel I made a change on the last commit for this pull request on the related instruction, please let me know if you think it can be ok as a first try, I am ready to change it again to fit the desired solution, and on that topic I am in need of your help

.filter(n -> Arrays.stream(Deployer.values()).anyMatch(e -> e.extension.equals(n)))

Thanks

[gsmet]

This is more complex than that. At the minimum, the .map(d -> strip(d.getArtifactId())) needs to be removed.

I created #36325 for @iocanel to have a closer look as I'm not entirely sure what's the right fix.

I would recommend to just revert the changes related to that so that we can get this merged as it might take some time for Ioannis to have a closer look at this.

[bmscomp]

@gsmet I made revert, to keep the existing behaviour on the last commit

[gsmet]

Thanks! I adjusted one small thing and squashed the commits. Let's wait for CI and merge.

[iocanel]

LGTM

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 791b933.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 integration-tests/reactive-messaging-kafka

✖ io.quarkus.it.kafka.KafkaConnectorTest.testFruits - History

• Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.it.kafka.KafkaConnectorTest.testFruits(KafkaConnectorTest.java:63)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)