-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use consistent versions of Maven for Maven wrapper and mvnd #36309
Conversation
To have the local build cache working, we need to use the same version of Maven for CI and local builds, which would be 3.9.3. mvnd has switched to Maven 4 in new versions so we will have to stick to these versions for a while.
@@ -14,6 +14,5 @@ | |||
# KIND, either express or implied. See the License for the | |||
# specific language governing permissions and limitations | |||
# under the License. | |||
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.8/apache-maven-3.8.8-bin.zip | |||
distributionSha256Sum=2e181515ce8ae14b7a904c40bb4794831f5fd1d9641107a13b916af15af4001a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, it seems they don't ship sha256 anymore and sha512 is not supported by the plugin.
Failing Jobs - Building 916ba58
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
✖
⚙️ Maven Tests - JDK 11 Windows #- Failing: integration-tests/maven
📦 integration-tests/maven✖
✖
✖
✖
|
To have the local build cache working, we need to use the same version of Maven for CI and local builds, which would be 3.9.3.
mvnd has switched to Maven 4 in new versions so we will have to stick to these versions for a while.
This is not really ideal and I'm not sure how well this will work in practice but I think that's the best we can do for now...