-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix codestart for kotlin serialization (Gradle, Gradle Kotlin and Maven) #36201
Conversation
This comment has been minimized.
This comment has been minimized.
a511011
to
bcd0476
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other failures don't look related and a rebase might help but the failures in KotlinSerializationCodestartTest
look related.
bcd0476
to
c774dd6
Compare
This comment has been minimized.
This comment has been minimized.
c774dd6
to
8db4125
Compare
This comment has been minimized.
This comment has been minimized.
@gsmet each time I rebase different errors :( |
8db4125
to
eff956f
Compare
This comment has been minimized.
This comment has been minimized.
fd61ced
to
87ded64
Compare
This comment has been minimized.
This comment has been minimized.
87ded64
to
ff738e7
Compare
This comment has been minimized.
This comment has been minimized.
@ia3andy probably a good thing to test locally before pushing to CI ^ |
ff738e7
to
cf4634a
Compare
I tested locally (just I missed one of them), I thought there was a problem in the codestart making the test fail on CI.. |
It should be fixed on the last commit |
if I start always running all the Quarkus CI on my machine for all PRs, I can stop working now :) |
This comment has been minimized.
This comment has been minimized.
@gsmet can we merge this? |
cf4634a
to
92716a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. I rebased to make sure CI still passes and then we can merge.
This comment has been minimized.
This comment has been minimized.
92716a4
to
08e0de6
Compare
This comment has been minimized.
This comment has been minimized.
08e0de6
to
c817e6a
Compare
I fixed the PR to take into account the Quarkus REST renaming. The failing tests are OK on my laptop now, I just hope I didn't break something else in passing, CI will be the judge of that :). |
Status for workflow
|
Fix #33622
Includes tests