Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codestart for kotlin serialization (Gradle, Gradle Kotlin and Maven) #36201

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Sep 28, 2023

Fix #33622

Includes tests

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Sep 28, 2023
@ia3andy ia3andy requested a review from gsmet September 28, 2023 13:54
@quarkus-bot

This comment has been minimized.

@ia3andy ia3andy force-pushed the fix-kotlin-serialization branch 2 times, most recently from a511011 to bcd0476 Compare September 28, 2023 14:25
@quarkus-bot

This comment has been minimized.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other failures don't look related and a rebase might help but the failures in KotlinSerializationCodestartTest look related.

@ia3andy ia3andy force-pushed the fix-kotlin-serialization branch from bcd0476 to c774dd6 Compare October 13, 2023 11:40
@quarkus-bot

This comment has been minimized.

@ia3andy ia3andy force-pushed the fix-kotlin-serialization branch from c774dd6 to 8db4125 Compare October 23, 2023 09:33
@ia3andy ia3andy requested a review from gsmet October 23, 2023 09:33
@quarkus-bot

This comment has been minimized.

@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 23, 2023

@gsmet each time I rebase different errors :(

@ia3andy ia3andy force-pushed the fix-kotlin-serialization branch from 8db4125 to eff956f Compare October 24, 2023 11:59
@quarkus-bot

This comment has been minimized.

@ia3andy ia3andy force-pushed the fix-kotlin-serialization branch 2 times, most recently from fd61ced to 87ded64 Compare October 24, 2023 15:29
@quarkus-bot

This comment has been minimized.

@ia3andy ia3andy force-pushed the fix-kotlin-serialization branch from 87ded64 to ff738e7 Compare October 25, 2023 08:34
@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Oct 25, 2023

@ia3andy probably a good thing to test locally before pushing to CI ^

@ia3andy ia3andy force-pushed the fix-kotlin-serialization branch from ff738e7 to cf4634a Compare October 25, 2023 15:38
@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 25, 2023

@ia3andy probably a good thing to test locally before pushing to CI ^

I tested locally (just I missed one of them), I thought there was a problem in the codestart making the test fail on CI..

@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 25, 2023

It should be fixed on the last commit

@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 25, 2023

if I start always running all the Quarkus CI on my machine for all PRs, I can stop working now :)
This ran CI too many times I agree, but this is unusual.

@quarkus-bot

This comment has been minimized.

@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 26, 2023

@gsmet can we merge this?

@gsmet gsmet force-pushed the fix-kotlin-serialization branch from cf4634a to 92716a4 Compare June 7, 2024 17:16
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I rebased to make sure CI still passes and then we can merge.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 7, 2024

This comment has been minimized.

@gsmet gsmet force-pushed the fix-kotlin-serialization branch from 92716a4 to 08e0de6 Compare June 8, 2024 09:31

This comment has been minimized.

@gsmet gsmet force-pushed the fix-kotlin-serialization branch from 08e0de6 to c817e6a Compare June 10, 2024 12:38
@gsmet
Copy link
Member

gsmet commented Jun 10, 2024

I fixed the PR to take into account the Quarkus REST renaming. The failing tests are OK on my laptop now, I just hope I didn't break something else in passing, CI will be the judge of that :).

Copy link

quarkus-bot bot commented Jun 10, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c817e6a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

📦 integration-tests/reactive-messaging-kafka

io.quarkus.it.kafka.KafkaConnectorTest.testFruits - History

  • Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.it.kafka.KafkaConnectorTest.testFruits(KafkaConnectorTest.java:63)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

@gsmet gsmet merged commit b7a98a1 into quarkusio:main Jun 10, 2024
52 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 10, 2024
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform kind/bugfix triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resteasy reactive kotlin serialization not completely configured after generating app from code.quarkus.io
3 participants