Remove link to Dev UI v1 as it is now gone #36116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/devtools
|
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
| @@ -255,7 +255,7 @@ <h1>You just made a Quarkus application.</h1> | |||
| <p>App configuration: <code>src/main/resources/{config.file-name}</code></p> | |||
| <p>Static assets: <code>src/main/resources/META-INF/resources/</code></p> | |||
| <p>Code: <code>{language.dir.code}</code></p> | |||
| <p>Dev UI V1: <a href="/q/dev-v1/">/q/dev-v1</a></p> | |||
| <p>Dev UI V1: <a href="/q/dev-ui/">/q/dev-v1</a></p> | |||
There was a problem hiding this comment.
V1 should be removed from the '<p>' as well
There was a problem hiding this comment.
hi @manofthepeace ,
Removed V1 from
, requesting for approval
phillip-kruger
added
the
triage/waiting-for-ci
This comment has been minimized.
This comment has been minimized.
gsmet
reviewed
Oct 3, 2023
| @@ -255,7 +255,7 @@ <h1>You just made a Quarkus application.</h1> | |||
| <p>App configuration: <code>src/main/resources/{config.file-name}</code></p> | |||
| <p>Static assets: <code>src/main/resources/META-INF/resources/</code></p> | |||
| <p>Code: <code>{language.dir.code}</code></p> | |||
| <p>Dev UI V1: <a href="/q/dev-v1/">/q/dev-v1</a></p> | |||
| <p>Dev UI: <a href="/q/dev-ui/">/q/dev-ui</a></p> | |||
There was a problem hiding this comment.
The Dev UI link is already present above. Let's drop this altogether. I will fine tune this and get this puppy home.
Co-authored-by: Guillaume Smet <[email protected]>
gsmet
force-pushed
the
bugfix/36109-welcome-page-error
branch
from
2347d5f to
a95dccf
Compare
gsmet
approved these changes
Oct 3, 2023
gsmet
changed the title
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #36109