Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make JBang Catalog calls from CLI not fatal #36111

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Make JBang Catalog calls from CLI not fatal #36111

merged 1 commit into from
Sep 26, 2023

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented Sep 22, 2023

Related to #36031

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus area/platform Issues related to definition and interaction with Quarkus Platform labels Sep 22, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 22, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with dot

This message is automatically generated by a bot.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 23, 2023

Failing Jobs - Building 1b60619

Status Name Step Failures Logs Raw logs Build scan
✖ JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 20

@iocanel iocanel changed the title Make JBang Catalog calls from CLI not fatal. Make JBang Catalog calls from CLI not fatal Sep 25, 2023
@iocanel
Copy link
Contributor Author

iocanel commented Sep 26, 2023

The failure is irrelevant.

@iocanel iocanel merged commit cebf54d into quarkusio:main Sep 26, 2023
49 of 50 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 26, 2023
@gsmet gsmet modified the milestones: 3.5 - main, 3.4.2 Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloubyansky aloubyansky aloubyansky approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
3.4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@iocanel @aloubyansky @gsmet