Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect user provided description of cli plugins #36097

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented Sep 22, 2023

Currently, the -d / --description option of quarkus plug add gets ingored.
This plugin address that.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Sep 22, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 22, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)
  • title should not start with chore/docs/feat/fix/refactor but be a proper sentence

This message is automatically generated by a bot.

@iocanel iocanel force-pushed the cli-description-fix branch from 1cdf8ca to ead5211 Compare September 22, 2023 13:32
@iocanel iocanel changed the title fix: respect user provide description of cli plugin Respect user provide description of cli plugin Sep 22, 2023
@iocanel iocanel changed the title Respect user provide description of cli plugin Respect user provided description of cli plugins Sep 22, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 22, 2023

Failing Jobs - Building ead5211

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 20

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: integration-tests/smallrye-context-propagation 

📦 integration-tests/smallrye-context-propagation

io.quarkus.context.test.SimpleContextPropagationTest.testArcTCContextPropagationDisabled line 92 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <2> but was: <3>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

@iocanel
Copy link
Contributor Author

iocanel commented Sep 22, 2023

Failures are unrelated.

@iocanel iocanel requested a review from aloubyansky September 25, 2023 05:02
@aloubyansky aloubyansky merged commit c9c0d5a into quarkusio:main Sep 26, 2023
50 of 51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 26, 2023
@gsmet gsmet modified the milestones: 3.5 - main, 3.4.2 Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants