Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OIDC Google example more complete #36060

Merged

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented Sep 21, 2023

Fixes #33053.

The well known providers doc already covers how to register a Google application, how to prepare and configure a REST client targeting one of its services, Calendar, but this PR makes it more complete, showing an example endpoint, straight from our demo.

CC @cescoffier

@sberyozkin sberyozkin requested a review from gastaldi September 21, 2023 10:59
@sberyozkin sberyozkin force-pushed the complete_google_calendar_example branch from c826eac to 68afb5f Compare September 21, 2023 11:04
@sberyozkin
Copy link
Member Author

Attempted to address a couple of Linting with Vale comments

@sberyozkin sberyozkin marked this pull request as draft September 21, 2023 11:32
@sberyozkin
Copy link
Member Author

Sorry, need to add a couple of images

@github-actions
Copy link

github-actions bot commented Sep 21, 2023

🙈 The PR is closed and the preview is expired.

@sberyozkin sberyozkin force-pushed the complete_google_calendar_example branch from 68afb5f to e5718d3 Compare September 21, 2023 12:52
@sberyozkin sberyozkin marked this pull request as ready for review September 21, 2023 12:52
@sberyozkin
Copy link
Member Author

Hi @gastaldi I've just pushed a minor update, including two images, showing what users have to do if they want to try the Quarkus endpoint

@sberyozkin
Copy link
Member Author

I'll update if you'll have some comments

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 21, 2023
@sberyozkin sberyozkin merged commit a984388 into quarkusio:main Sep 21, 2023
5 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Sep 21, 2023
@sberyozkin sberyozkin deleted the complete_google_calendar_example branch September 21, 2023 13:55
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 21, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 21, 2023
@gsmet gsmet modified the milestones: 3.5 - main, 3.4.2 Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

Document happy path Google auth and augmentation
4 participants