Log error when project cannot be created #36057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metacosm
force-pushed
the
debug-project
branch
from
a6c3946 to
fb0a965
Compare
metacosm
force-pushed
the
debug-project
branch
from
fb0a965 to
995ad3b
Compare
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
gsmet
reviewed
Sep 21, 2023
| @@ -139,6 +143,7 @@ public static Optional<Project> createProject(ApplicationInfoBuildItem app, | |||
| buildInfo, project.getScmInfo())); | |||
|
|
|||
| } catch (Exception e) { | |||
| LOG.debugv(e, "Couldn't create project for {0} application", name); | |||
There was a problem hiding this comment.
Should it be debug or does it have value for the user?
There was a problem hiding this comment.
I debated using info level… the problem is that the exception you usually get is not really actionable as-is since you get exceptions like the one seen in #36041. Maybe if dekorate was returning more informative exceptions, it would make more sense to use an info level here.
|
I will let @iocanel have the final say on this as some changes might be needed in Dekorate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.