-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite the Vert.x MDC tests to be more robust #36010
Rewrite the Vert.x MDC tests to be more robust #36010
Conversation
This comment has been minimized.
This comment has been minimized.
Quarkus CI / JVM Tests - JDK 17 (pull_request) Successful in 3m ..... yeah sure.... |
ah no, it only ran the updated modules... nice! |
Yeah, that's the GIB Maven extension (from @famod) at work :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will rerun them once to have another run.
This comment has been minimized.
This comment has been minimized.
Doesn't look good ^ |
Yeah... I will have another look tomorrow. I was hoping it was the remote service, but it's not. I need to look under the hood, it might be a real bug, not just a test issue. |
f73952d
to
6f7f211
Compare
This comment has been minimized.
This comment has been minimized.
6f7f211
to
21d78e5
Compare
Failing Jobs - Building 21d78e5
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/vertx/deployment
📦 extensions/vertx/deployment✖
⚙️ JVM Tests - JDK 17 #- Failing: extensions/vertx/deployment
📦 extensions/vertx/deployment✖
⚙️ JVM Tests - JDK 17 Windows #- Failing: extensions/vertx/deployment
📦 extensions/vertx/deployment✖
⚙️ JVM Tests - JDK 20 #- Failing: extensions/vertx/deployment
📦 extensions/vertx/deployment✖
|
21d78e5
to
ddfcafd
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
We had a green build. I just started the whole pipeline again to see. The PR:
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Another green run, let's merge and see if I need to revisit them again later. |
@gsmet as requested, let's see how it goes....
My rewrite does not call a remove service (which can be very slow and stop responding).