Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the Vert.x MDC tests to be more robust #36010

Merged

Conversation

cescoffier
Copy link
Member

@cescoffier cescoffier commented Sep 19, 2023

@gsmet as requested, let's see how it goes....

My rewrite does not call a remove service (which can be very slow and stop responding).

@quarkus-bot

This comment has been minimized.

@cescoffier
Copy link
Member Author

I don't believe the CI ran successfully... @gsmet @geoand any idea?

@cescoffier
Copy link
Member Author

Quarkus CI / JVM Tests - JDK 17 (pull_request) Successful in 3m ..... yeah sure....

@cescoffier
Copy link
Member Author

ah no, it only ran the updated modules... nice!

@geoand
Copy link
Contributor

geoand commented Sep 19, 2023

Yeah, that's the GIB Maven extension (from @famod) at work :)

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will rerun them once to have another run.

@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Sep 19, 2023

Doesn't look good ^

@cescoffier
Copy link
Member Author

Yeah... I will have another look tomorrow. I was hoping it was the remote service, but it's not.

I need to look under the hood, it might be a real bug, not just a test issue.

@cescoffier cescoffier force-pushed the attempt-to-fix-the-vertx-mdc-test branch from f73952d to 6f7f211 Compare September 20, 2023 06:34
@quarkus-bot

This comment has been minimized.

@cescoffier cescoffier force-pushed the attempt-to-fix-the-vertx-mdc-test branch from 6f7f211 to 21d78e5 Compare September 20, 2023 07:14
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 20, 2023


🌘 This workflow status is outdated as a new workflow run has been triggered.


Failing Jobs - Building 21d78e5

Status Name Step Failures Logs Raw logs Build scan
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
JVM Tests - JDK 20 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/vertx/deployment 

📦 extensions/vertx/deployment

io.quarkus.vertx.mdc.VertxMDCDevModeTest.mdcDevMode line 45 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined in void io.quarkus.vertx.mdc.VertxMDCDevModeTest.mdcDevMode() log doesn't contain: Received HTTP request ### 55088c77-bd7b-46d2-b327-64b7ec645b76 ==> expected: <true> but was: <false> within 2 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/vertx/deployment 

📦 extensions/vertx/deployment

io.quarkus.vertx.mdc.VertxMDCDevModeTest.mdcDevMode line 45 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined in void io.quarkus.vertx.mdc.VertxMDCDevModeTest.mdcDevMode() log doesn't contain: Received HTTP request ### 92760c3b-da8c-4080-9a25-78b641180e9b ==> expected: <true> but was: <false> within 2 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/vertx/deployment 

📦 extensions/vertx/deployment

io.quarkus.vertx.mdc.VertxMDCDevModeTest.mdcDevMode line 45 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined in void io.quarkus.vertx.mdc.VertxMDCDevModeTest.mdcDevMode() log doesn't contain: Received HTTP request ### 2214f438-d661-455b-a580-29e18ac6e59d ==> expected: <true> but was: <false> within 2 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

⚙️ JVM Tests - JDK 20 #

- Failing: extensions/vertx/deployment 

📦 extensions/vertx/deployment

io.quarkus.vertx.mdc.VertxMDCDevModeTest.mdcDevMode line 45 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined in void io.quarkus.vertx.mdc.VertxMDCDevModeTest.mdcDevMode() log doesn't contain: Received HTTP request ### c4ea2097-2f71-44a0-b0d2-ed1072775500 ==> expected: <true> but was: <false> within 2 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

@cescoffier cescoffier force-pushed the attempt-to-fix-the-vertx-mdc-test branch from 21d78e5 to ddfcafd Compare September 21, 2023 14:21
@quarkus-bot

This comment has been minimized.

1 similar comment
@quarkus-bot

This comment has been minimized.

@cescoffier
Copy link
Member Author

We had a green build.
I ran the windows tests again to ensure it was not just chance.

I just started the whole pipeline again to see.


The PR:

  • removes the external service. It can be slow or even block our requests (rate limiting / blacklisting)
  • makes sure we wait for the log handler to be in the delayed handler list before starting to execute the tests

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 22, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@cescoffier
Copy link
Member Author

Another green run, let's merge and see if I need to revisit them again later.

@cescoffier cescoffier merged commit af4208a into quarkusio:main Sep 22, 2023
19 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 22, 2023
@cescoffier cescoffier deleted the attempt-to-fix-the-vertx-mdc-test branch September 22, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants