Integrate @ShouldPin/@ShouldNotPin into QuarkusTests #35992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
|
Do not merge, we are still discussing if it should be in-quarkus or outside. |
geoand
added
the
triage/needs-decision
ozangunalp
approved these changes
Sep 19, 2023
...it5-virtual-threads/src/main/java/io/quarkus/test/junit/virtual/internal/InternalEvents.java
Outdated
Show resolved
Hide resolved
cescoffier
force-pushed
the
loom-unit-integration
branch
from
9c30a25 to
b52bc97
Compare
cescoffier
removed
the
triage/needs-decision
|
After discussion, we decided to move the junit5 extension under independent projects, to allow other projects to use it. The functionality is not Quarkus-specific. The PR has been updated. |
This commit brings the functionality from loom-unit (partially, but the important ones are there) into Quarkus. Thus, @ShouldPin and @ShouldNotPin can be used on a @QuarkusTest directly as soon as the junit5-virtual-threads dependency is in the project and the extension declared on the test case with the `io.quarkus.test.junit5.virtual.VirtualThreadUnit` annotation. loom-unit original repo: https://github.com/cescoffier/loom-unit
cescoffier
force-pushed
the
loom-unit-integration
branch
from
b52bc97 to
8d80397
Compare
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the functionality from loom-unit (partially, but the important ones are there) into Quarkus.
Thus, @ShouldPin and @ShouldNotPin can be used on a @QuarkusTest directly as soon as the quarkus-junit5-virtual-threads dependency is in the project.
loom-unit original repo: https://github.com/cescoffier/loom-unit