Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More hierarchical classes are not picked up as global interceptors #35876

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

alesj
Copy link
Contributor

@alesj alesj commented Sep 12, 2023

Missing interfaces check when looking for global server interceptors.

Fixes #35634

@quarkus-bot quarkus-bot bot added the area/grpc gRPC label Sep 12, 2023
@alesj alesj requested a review from cescoffier September 12, 2023 11:49
@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Sep 12, 2023

Imports need to be sorted :)

@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 12, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@cescoffier cescoffier merged commit 3bfd85a into quarkusio:main Sep 13, 2023
25 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 13, 2023
@aloubyansky
Copy link
Member

@cescoffier to backport this one to 3.2 cleanly, we'd need to backaport #34348 as well. Do we want both in 3.2?

@cescoffier
Copy link
Member

@aloubyansky we should backport both if it does merge cleanly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extends ServerInterceptor not working
4 participants