Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute: add arguments metadata for user-defined tags #35818

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Sep 8, 2023

Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!

@ia3andy
Copy link
Contributor

ia3andy commented Sep 8, 2023

@mkouba maybe you can have a test with the example from the issue?

@mkouba mkouba force-pushed the qute_user_tag_arguments branch from 8484558 to ce8130d Compare September 8, 2023 12:59
@mkouba mkouba force-pushed the qute_user_tag_arguments branch from ce8130d to e0b23ea Compare September 8, 2023 13:01
@mkouba
Copy link
Contributor Author

mkouba commented Sep 8, 2023

@mkouba maybe you can have a test with the example from the issue?

I've added a test adapted from the issue ;-)

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 8, 2023

Failing Jobs - Building e0b23ea

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 20 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 20 #

- Failing: devtools/cli 

📦 devtools/cli

io.quarkus.cli.CliProjectJBangTest.testCreateAppDefaults line 64 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {

io.quarkus.cli.CliProjectJBangTest.testCreateCliDefaults line 127 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {

io.quarkus.cli.CliProjectJBangTest.testCreateAppOverrides line 98 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {

@geoand geoand merged commit 5d072a3 into quarkusio:main Sep 11, 2023
52 of 54 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Sep 11, 2023
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 11, 2023
@github-actions
Copy link

🙈 The PR is closed and the preview is expired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation area/qute The template engine kind/enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Allow to have params propagation from Qute tags to underlying element
3 participants