Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OTel to 1.29.0 #35733

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Bump OTel to 1.29.0 #35733

merged 1 commit into from
Sep 19, 2023

Conversation

brunobat
Copy link
Contributor

@brunobat brunobat commented Sep 5, 2023

No description provided.

@brunobat brunobat marked this pull request as ready for review September 5, 2023 11:27
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/tracing labels Sep 5, 2023
@brunobat brunobat requested a review from alesj September 5, 2023 11:27
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 5, 2023

/cc @radcortez (opentelemetry)

@brunobat brunobat requested a review from radcortez September 5, 2023 11:27
@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Sep 6, 2023

@yrodiere this is another case of OOM due to metaspace. It might be a coincidence but it's often failing in this particular test.

@brunobat
Copy link
Contributor Author

brunobat commented Sep 6, 2023

I see gradle cache in the stack traces and jobs running for almost 6h with logs ending abruptly.

@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Sep 12, 2023

@brunobat the native failures in the new report look related.

@brunobat
Copy link
Contributor Author

These com.gradle.maven.cache.extension.* stacktrace errors in the build log are confusing.
It should be good now, @gsmet

@brunobat
Copy link
Contributor Author

@geoand Do you mind if I merge this? I need to work in the next upgrade...

@geoand
Copy link
Contributor

geoand commented Sep 19, 2023

Go for it once CI is done :)

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 19, 2023
@gsmet
Copy link
Member

gsmet commented Sep 19, 2023

These com.gradle.maven.cache.extension.* stacktrace errors in the build log are confusing.

@brunobat could you be more specific?

@brunobat
Copy link
Contributor Author

brunobat commented Sep 19, 2023

These com.gradle.maven.cache.extension.* stacktrace errors in the build log are confusing.

@brunobat could you be more specific?

Yes @gsmet . Please check the exceptions on the end of this old log file:
https://github.com/quarkusio/quarkus/commit/ed2568eee25ffbe2d9d3423b6d875d219bffe370/checks/16581210435/logs

@gsmet
Copy link
Member

gsmet commented Sep 19, 2023

OK. So the build cache adds a layer and that's what you see in the stacktraces. There's nothing we can do about it really but I don't think this is as confusing as it seems. I'll send an email to the list.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 19, 2023

Failing Jobs - Building 7148730

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 20

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/smallrye-graphql/deployment 
! Skipped: extensions/micrometer-registry-prometheus/deployment extensions/micrometer/deployment extensions/opentelemetry/deployment and 38 more

📦 extensions/smallrye-graphql/deployment

io.quarkus.smallrye.graphql.deployment.RequestLeakDetectionTest.testWithConcurrentCalls line 55 - More details - Source on GitHub

BUG! exception in phase 'class generation' in source unit 'Script1.groovy' unexpected NullPointerException
	at org.codehaus.groovy.control.CompilationUnit$IPrimaryClassNodeOperation.doPhaseOperation(CompilationUnit.java:942)
	at org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:692)

@geoand geoand merged commit 7903aa7 into quarkusio:main Sep 19, 2023
50 of 51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 19, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 19, 2023
@brunobat brunobat deleted the bump-otel-1-29 branch October 17, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants