Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuarkusComponentTest: register additional annotations transformers #35719

Merged
merged 1 commit into from
Sep 5, 2023
Merged

QuarkusComponentTest: register additional annotations transformers #35719

merged 1 commit into from
Sep 5, 2023

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Sep 4, 2023

@mkouba
QuarkusComponentTest: register additional annotations transformers
429dbfd 
- introduce JaxrsSingletonTransformer to add Singleton to a JAX-RS
component that has no scope
- resolves quarkusio#35313
@mkouba
Copy link
Contributor Author

mkouba commented Sep 4, 2023

IMPL. NOTE: I don' think it would make sense to introduce a new API similar to AutoAddScopeBuildItem and BeanDefiningAnnotationBuildItem. So instead let's reuse the AnnotationsTransformer API. It's a bit too low level but we don't expect regular users to implement it...

@Ladicek
Copy link
Contributor

Ladicek commented Sep 4, 2023

I'm not sure if this is entirely useful, but the code seems fine :-)

@mkouba
Copy link
Contributor Author

mkouba commented Sep 4, 2023

I'm not sure if this is entirely useful, but the code seems fine :-)

JaxrsSingletonTransformer is the useful part (and ofc this does not even require the user-facing API ;-). But we could add other transformers in the future... and users can do as well.

@mkouba mkouba marked this pull request as ready for review September 4, 2023 14:42
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 4, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@mkouba mkouba merged commit 50b4e07 into quarkusio:main Sep 5, 2023
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Sep 5, 2023
@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

@manovotn manovotn Awaiting requested review from manovotn

@holly-cummins holly-cummins Awaiting requested review from holly-cummins

Assignees
No one assigned
Labels
area/testing kind/enhancement New feature or request
Projects
None yet
Milestone
3.4.0.CR1
Development

Successfully merging this pull request may close these issues.

QuarkusComponentTest: provide API to turn a class that is not annotated with a scope into a bean
2 participants
@mkouba @Ladicek