Use correct default config source name to check Kubernetes config disabled #35696
Conversation
radcortez
commented
Sep 2, 2023
radcortez
commented
- Fixes Kubernetes secret not read anymore in 3.3 #35673
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
|
@radcortez do you know if 3.2 is affected? If so, we need to backport it. |
| @@ -84,7 +84,7 @@ Iterable<ConfigSource> getConfigSources(final KubernetesConfigSourceConfig confi | |||
|
|
|||
| private boolean isExplicitlyDisabled(ConfigSourceContext context) { | |||
| ConfigValue configValue = context.getValue("quarkus.kubernetes-config.enabled"); | |||
| if (AbstractRawDefaultConfigSource.NAME.equals(configValue.getConfigSourceName())) { | |||
| if ("DefaultValuesConfigSource".equals(configValue.getConfigSourceName())) { | |||
There was a problem hiding this comment.
Should it be a constant? IS the other constant still in use?
There was a problem hiding this comment.
My understanding is that this will go away when the TODO is implemented
There was a problem hiding this comment.
Yes, I need to improve this a bit. This was a migration as is, so I didn't want to introduce other changes as well. As for the constant, the source is provided by SR Config, so I prefer to add the constant there.
For 3.2 no. This was introduced with #34457. The issue is that the Default source for mappings have a different name, so the behaviour was not the same. |
