Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenShiftClientProducer tests #35650

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

manusa
Copy link
Contributor

@manusa manusa commented Aug 31, 2023

Description

Closes #35525

As discussed, #35525 can't be merged since there is no support for the @Specializes annotation.

This PR contains the tests that were introduced in #35525 to ensure the behavior of the beans provided by OpenShiftClientProducer.

From #35525 (comment):

  • BeanDefaultsTest: A user is able to inject KubernetesClient and OpenShiftClient fields.
    The injected KubernetesClient instance should be the one produced by OpenShiftClientProducer (OpenShiftClient)
  • BeanOverridesTest: A user is able to override the default OpenShiftClient with their own instance and producer method without providing further configurations or annotations.
    (requires that all of our producer methods are annotated with @DefaultBean. Requires our processor methods to remove one of the producers in case both extensions coexist.)

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 31, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit c4f3ced into quarkusio:main Aug 31, 2023
@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Aug 31, 2023
@manusa manusa deleted the test/kubernetes-client-beans branch August 31, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants