Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the @generated annotation $$accessor classes #35629

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Aug 30, 2023

This is done to keep code coverage classes happy.

An example of an accessor is now:

package io.quarkus.runtime;

@io.quarkus.Generated("Quarkus annotation processor")
public final class DebugRuntimeConfig$$accessor {
    private DebugRuntimeConfig$$accessor() {}
    @SuppressWarnings("unchecked")
    public static boolean get_printStartupTimes(Object __instance) {
        return ((DebugRuntimeConfig)__instance).printStartupTimes;
    }
    @SuppressWarnings("unchecked")
    public static void set_printStartupTimes(Object __instance, boolean printStartupTimes) {
        ((DebugRuntimeConfig)__instance).printStartupTimes = printStartupTimes;
    }
}

Closes: #35601

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 30, 2023
@gsmet
Copy link
Member

gsmet commented Aug 30, 2023

Is there a reason why we are not using the standard Generated annotation they introduced in the JDK recently? I don’t remember where they put it handy but I’m sure they added one.

@geoand
Copy link
Contributor Author

geoand commented Aug 30, 2023

You mean javax.annotation.processing.Generated?

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 30, 2023

Failing Jobs - Building 03f5f06

Status Name Step Failures Logs Raw logs Build scan
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 20

@geoand geoand merged commit 2aabdbe into quarkusio:main Aug 30, 2023
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Aug 30, 2023
@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Aug 30, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a @Generated annotation on all generated code
3 participants