Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev UI: Change to use composite vaadin #35625

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

phillip-kruger
Copy link
Member

This PR change to use vaadin as a composite jar (new feature in mvnpm) that makes the dependencies much less, as discussed with @aloubyansky .

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/vertx labels Aug 30, 2023
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 30, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@phillip-kruger phillip-kruger merged commit 0e143cf into quarkusio:main Aug 30, 2023
@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/vertx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants