Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve latency of CLI plugin commands #35620

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Improve latency of CLI plugin commands #35620

merged 3 commits into from
Sep 20, 2023

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented Aug 29, 2023

The pull request adds the following improvements:

  • cache jbang version to avoid multiple jbang calls
  • reconcile focuses on installed plugin types (avoid uneeded calls to jbang).
  • limit the cases where we check for jbang installation.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus area/platform Issues related to definition and interaction with Quarkus Platform labels Aug 29, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 29, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with dot

This message is automatically generated by a bot.

@iocanel iocanel marked this pull request as ready for review September 1, 2023 13:43
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 1, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet changed the title Improve latency of CLI plug commans. Improve latency of CLI plugin commands Sep 12, 2023
@iocanel
Copy link
Contributor Author

iocanel commented Sep 14, 2023

Failures are unrelated.

@gsmet gsmet merged commit e929e65 into quarkusio:main Sep 20, 2023
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants