Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config doc - Avoid processing methods if not @ConfigMapping #35618

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Aug 29, 2023

Fixes #35594

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this bug really is only about documentation. Good :)

LGTM, thanks!

@gsmet
Copy link
Member Author

gsmet commented Aug 29, 2023

Note: I will have to regenerate and push the documentation for 3.2 after this as it's not looking pretty.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 29, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit 6c9fa0a into quarkusio:main Aug 29, 2023
@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Aug 29, 2023
@gsmet gsmet modified the milestones: 3.4 - main, 3.3.2 Sep 4, 2023
@gsmet gsmet modified the milestones: 3.3.2, 3.2.7.Final Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Openshift deployment config properties all start with get-/is-
2 participants