Mockito testing - manually activate req. context when creating Mockito spies #35606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Ladicek
reviewed
Aug 29, 2023
integration-tests/injectmock/src/test/java/io/quarkus/it/mockbean/RequestScopedSpyTest.java
Outdated
Show resolved
Hide resolved
Ladicek
approved these changes
Aug 29, 2023
This comment has been minimized.
This comment has been minimized.
Good point @Ladicek; I have now made use of |
This comment has been minimized.
This comment has been minimized.
geoand
reviewed
Aug 30, 2023
...mockito/src/main/java/io/quarkus/test/junit/mockito/internal/CreateMockitoSpiesCallback.java
Outdated
Show resolved
Hide resolved
geoand
requested changes
Aug 30, 2023
geoand
added
the
triage/waiting-for-ci
manovotn
removed
the
triage/waiting-for-ci
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
|
Hm, this might not have been right - I am just discussing it with Martin. |
|
👌🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35581
Allows to use req. scoped Mockito spies.
ATM we initialize all spies right after creation of test instance - this is fine except there is no req. scope active because we active that for each test method. This fix activates/deactivates req. context when creating spies.