Integrate @RunOnVirtualThread with the @ConsumeEvent #35585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/documentation
area/infra-automation
|
I'm unhappy with the change in the virtual thread extension to avoid the dependency cycle. I wonder if we should just merge that extension in the vert.x one. |
This comment has been minimized.
This comment has been minimized.
|
🙈 The PR is closed and the preview is expired. |
cescoffier
force-pushed
the
virtual-threads-consume-event
branch
from
c14639b to
5661a27
Compare
mkouba
reviewed
Aug 28, 2023
mkouba
reviewed
Aug 28, 2023
...ts/virtual-threads/vertx-event-bus-virtual-threads/src/main/resources/application.properties
Show resolved
Hide resolved
mkouba
reviewed
Aug 28, 2023
...event-bus-virtual-threads/src/test/java/io/quarkus/virtual/vertx/RunOnVirtualThreadTest.java
Outdated
Show resolved
Hide resolved
mkouba
reviewed
Aug 28, 2023
.../vertx-event-bus-virtual-threads/src/test/java/io/quarkus/virtual/vertx/NoPinningVerify.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Allows @ConsumeEvent method to run on a virtual thread. Also verify that sending and receiving from the event bus is not pinning the carrier thread.
cescoffier
force-pushed
the
virtual-threads-consume-event
branch
from
5661a27 to
b098487
Compare
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows @ConsumeEvent method to run on a virtual thread.
Also verify that sending and receiving from the event bus is not pinning the carrier thread.