Fix "my second guide" title, and cross-link #35571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me do some experiments on the website before merging this. |
|
🎊 PR Preview e929e65 has been successfully built and deployed to https://quarkus-pr-main-35571-preview.surge.sh/version/main/guides/ |
gsmet
requested changes
Aug 25, 2023
| @@ -4,17 +4,20 @@ and pull requests should be submitted there: | |||
| https://github.com/quarkusio/quarkus/tree/main/docs/src/main/asciidoc | |||
| //// | |||
|
|
|||
| [id="getting-started-dev-services-tutorial"] | |||
There was a problem hiding this comment.
You can keep that, what you need is to get rid of the new line above.
See quarkusio/quarkusio.github.io@a30a2d5 and https://quarkus.io/guides/getting-started-dev-services
…d try and sort out title of second application guide.
gsmet
force-pushed
the
second-application-guide-tweaks
branch
from
18f78e4 to
966c4df
Compare
gsmet
approved these changes
Sep 20, 2023
gsmet
added
the
triage/waiting-for-ci
|
Thank you, @gsmet! |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
gsmet
added
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know how we didn't notice this in preview, but despite having a title, the title for "my second application" is generated nonsense:
The adoc looks fine in an adoc editor, so I'm not sure what's wrong. I've tried removing the id to see if that helps.
I've also cross-linked from the first application guide to the second application guide.