Remove duplicated HTTP body size limit check

[snazy]

Also removes the duplicate addition of the body-size-limit enforcer.

[cescoffier]

(copied from zulip)

That's the opposite. That would be the management one to remove, and only if it's mounted on a router having it already.
So, keep the one line 425 and remove the one line 553.

[cescoffier]

I think it should work as expected now.
Does your case pass?

[snazy]

@cescoffier it does with the .order(-3)

[cescoffier]

Yes, because your route must be the first.
I wonder which routes are at index -2 and -1...

[snazy]

-2 is the body-size-check.
Haven't seen any route for -1 though

[cescoffier]

I think we should start having constants (and documentation) around these numbers.

[snazy]

I think we should start having constants (and documentation) around these numbers.

Makes sense. Want me to do that in this PR or better have a follow-up?

[cescoffier]

Let's do it in another PR. That one is ready from my POV.

[cescoffier]

Can you rebase? It should be good to go.

[snazy]

Can you rebase?

Sure, done.

[quarkus-bot]

Failing Jobs - Building 5bee7fc

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✔️	JVM Tests - JDK 11
✔️	JVM Tests - JDK 17
✖	JVM Tests - JDK 17 Windows	Build	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 20
✖	Native Tests - Virtual Thread - Messaging	Update Docker Client User Agent	⚠️ Check →	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: integration-tests/smallrye-context-propagation 

📦 integration-tests/smallrye-context-propagation

✖ io.quarkus.context.test.SimpleContextPropagationTest.testArcTCContextPropagationDisabled line 92 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <2> but was: <3>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

[cescoffier]

Thanks!