Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close DevServices in a timely manner for integration tests #35486

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Aug 23, 2023

Fixes: #35464

This needs to done for QuarkusMainIntegrationTestExtension

@geoand geoand changed the title Close DevServices in a timely manner for @QuarkusIntegrationTest Close DevServices in a timely manner for integration tests Aug 23, 2023
@geoand geoand marked this pull request as ready for review August 23, 2023 14:53
@geoand geoand requested a review from gastaldi August 23, 2023 14:53
@quarkus-bot

This comment has been minimized.

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 24, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 24, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit 7bcbb88 into quarkusio:main Aug 24, 2023
@geoand geoand deleted the #35464 branch August 24, 2023 10:32
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 24, 2023
@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev Service Containers are not stopped between test classes
2 participants